[WIP] Introducing PCS codebase as a separate module #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
reviewed
Mar 12, 2024
There was a problem hiding this comment.
I think the commitment-related1 parts of :
kzg_commitment.rspedersen.rs
should stay out of the PCS module, because the traits they are dedicated to implementing are unrelated to theEvaluationEngine. They could be in their owncommitmentmodule if you like.
Footnotes
-
I do not consider the implementation of
CommitmentKeyExtTraitfor the pedersen commitment to be commitment-related, and in fact it's only used by the IPA. So that trait implementation could move to the PCS module. ↩
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #304.
Reorganises PCS codebase into a separate module.
Moves vanilla KZG10 utilities from ZM.
Still work in progress